added tree to dynamic apps#84
Open
sinamhdv wants to merge 1 commit into
Open
Conversation
Added required libaries, README.md, and main binary for tree to be used with Unikraft bincompat mode. Signed-off-by: Sina Mahdavi <sinamhdv@gmail.com>
StefanJum
requested changes
Sep 25, 2023
Member
StefanJum
left a comment
StefanJum
left a comment
There was a problem hiding this comment.
Looks good, see the comments and please add a section on running the command on Linux (see this example of README)
| ../extract.sh usr/bin/tree | ||
| ``` | ||
|
|
||
| ``` |
|
|
||
| Output: | ||
|
|
||
| ``` |
razvand
requested changes
Sep 25, 2023
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Rewrite commit message to:
Add tree command
Add `tree` binary, together with the required libaries and `README.md`to be used with Unikraft's bincompat mode.
| `-- bin | ||
| `-- tree | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Remove extra white line at the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added required libaries, README.md, and main binary for tree to be used with Unikraft bincompat mode.