Implement audit logging for all workflow actions - #90
Closed
kael-developer[bot] wants to merge 1 commit into
Closed
Conversation
Implemented by Kael AI Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Problem
There is currently no trace of who created, started, paused, resumed, or modified a workflow, which hinders compliance, security auditing, and debugging.
Solution
Add an
audit_logstable (user_id, action, workflow_id, timestamp, details). In the FastAPI app, create middleware that captures authenticated requests and logs the action. Extend CLI commands to emit structured audit entries using the same logger. Provide a secure API endpoint (/audit) to query logs with filters.Value
Provides a complete, tamper‑evident trail of all user actions, satisfying audit requirements and simplifying incident investigations.
Implementation notes
Define the
AuditLogmodel in the storage package. Implement a FastAPI dependency that records each request after successful authentication. Hook into Click command callbacks to write logs (using the same DB session). Add pagination and filtering to the/auditendpoint. Include unit and integration tests.Priority: P1
Implementation summary
Lines 37-40 are stray duplicate struct fields not part of any type. Should be removed entirely. We'll replace them with nothing.
Closes #84