docs(v1): fix node preset import in README example#551
Open
SinhSinhAn wants to merge 1 commit into
Open
Conversation
The example under the `node` preset section imports `nodeless` but
the code immediately below calls `env(node, {})`, which is the
correct preset for that section. Fixed the import to match.
Closes unjs#509.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #509.
The example under the
### nodepreset section in the v1 README importsnodelessbut the line right below callsenv(node, {}). The import is the typo — the section is documenting thenodepreset, so the import should be{ env, node }. The other preset sections (nodeless,deno, etc.) all import the matching name.One-character README change, no source code touched, no behaviour change. Targeting
v1since that's the branch the npm-published README comes from.AI disclosure: I used Claude to locate the line in the v1 README and to draft this PR description. The fix itself is a single-word edit that matches the reporter's suggestion in #509.