Skip to content

fix(schema-org): export missing node types - #852

Merged
harlan-zw merged 1 commit into
mainfrom
fix/export-missing-public-types
Jul 19, 2026
Merged

fix(schema-org): export missing node types#852
harlan-zw merged 1 commit into
mainfrom
fix/export-missing-public-types

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #822

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

definePlace() and defineVirtualLocation() are public, and schema inputs already reference shipping and returns types, but those types could not be imported from @unhead/schema-org. This exports the existing location and commerce node types from the package entry and covers each export with public type tests. It only adds type exports; runtime code and existing consumer types are unchanged.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 74d4473a-729c-4cfa-8cba-c9746519fe7a

📥 Commits

Reviewing files that changed from the base of the PR and between cf40679 and 357b0fa.

📒 Files selected for processing (2)
  • packages/schema-org/src/index.ts
  • packages/schema-org/test/public-types.test.ts

📝 Walkthrough

Walkthrough

The schema.org package now re-exports additional node-specific TypeScript types from its top-level entry point. Public type tests import these types and verify required properties, Simple-type equivalence, and delivery transit-time typing.

Changes

Schema.org public types

Layer / File(s) Summary
Public type exports and validation
packages/schema-org/src/index.ts, packages/schema-org/test/public-types.test.ts
The entry point re-exports additional schema.org types, while public type tests verify their expected properties and Simple type relationships.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately summarizes the main change of exporting missing node types.
Description check ✅ Passed The description includes a clear summary, motivation, and testing details, matching the template well enough despite minor optional omissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/export-missing-public-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size

No notable changes

All bundles (14)
Bundle Gzipped Brotli Raw
Core
Client (Minimal) 5.2 kB 4.7 kB 12.9 kB
Client (Full) 8.6 kB 7.8 kB 22.1 kB
Client (Self-Contained) 5.5 kB 5 kB 13.6 kB
Server (Minimal) 4.7 kB 4.3 kB 11.8 kB
Server (Self-Contained) 5.1 kB 4.5 kB 12.4 kB
Vue
Vue Client (Minimal) 5.7 kB 5.2 kB 14 kB
Vue Client (Full) 9.3 kB 8.5 kB 24.1 kB
Vue Server (Minimal) 5.2 kB 4.7 kB 12.8 kB
React
React Client (Minimal) 5.6 kB 5.1 kB 13.9 kB
React Client (Full) 9.4 kB 8.6 kB 24.5 kB
React Server (Minimal) 5 kB 4.5 kB 12.4 kB
Schema.org
Schema.org (Minimal) 9.7 kB 8.8 kB 26.8 kB
Schema.org Imports 0.1 kB 0.1 kB 0.1 kB
Schema.org Vue Meta 0.4 kB 0.3 kB 0.8 kB

⚡ Performance (directional)

No significant change (within CI noise)

All benchmarks (14)
Benchmark PR Δ RME
SSR render (CPU) 0.382 ms ~ noise ±11.9%
SSR render (wall) 0.264 ms ~ noise ±6.3%
SSR allocated / render 262.1 KiB ~ noise
Schema.org cached render (CPU) 0.374 ms ~ noise ±5.9%
Schema.org cached render (wall) 0.248 ms ~ noise ±2.4%
Schema.org cached allocated / render 144.6 KiB ~ noise
Streaming wrapStream drain (CPU) 0.265 ms ~ noise ±4.5%
Streaming wrapStream drain (wall) 0.153 ms ~ noise ±4.2%
Streaming allocated / drain 160.6 KiB ~ noise
Streaming suspense chunk (CPU) 0.011 ms ~ noise ±5.8%
Streaming allocated / suspense chunk 4.6 KiB ~ noise
CSR DOM mutations / nav 38 ~ noise
CSR re-render (CPU) 0.848 ms ~ noise ±5.0%
CSR re-render (wall) 0.486 ms ~ noise ±2.1%

Baseline: main @ cf40679 · 2026-07-19 · gzipped is the headline size metric · perf is directional (shared-runner, gated)

@harlan-zw
harlan-zw merged commit f5bf547 into main Jul 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant