fix(cli): review --issues가 항상 Filed 0 수정 (INT-1969)#149
Merged
Conversation
…우회 (INT-1969) 원인 2가지: 1. CLI 단독 실행은 Linear init/setTaskSource를 안 해(데몬 service.ts만) getTaskSource()=null → 즉시 0. 2. fileReviewerFollowups가 approve일 때만 파일링 → 수동 review가 revise/reject면 0. 수정: - runnerExecution.fileReviewerFollowups: requireApprove(기본 true) 옵션. 수동 review는 false. - reviewCommand.ensureTaskSource(): getTaskSource null이면 config로 Linear init (OAuth profile/apiKey) 후 LinearTaskSource 생성. 미설정이면 null. - 파일링 결과 0이면 'Is Linear connected? openswarm auth login --provider linear' 안내. 테스트: requireApprove=false(revise도 파일링) + ensureTaskSource 경유 + 0건 안내. 전체 1160 green. INT-1968 후속(사용자 보고).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
openswarm review --issues가 항상Filed 0로 끝나 실제 이슈가 안 생김(사용자 보고).원인 2가지
getTaskSource()=null → 즉시 0.fileReviewerFollowups가decision==='approve'일 때만 파일링 → 수동 review가 revise/reject면 0.수정
fileReviewerFollowups:requireApprove(기본 true) 옵션 — 수동 review는 false.reviewCommand.ensureTaskSource(): getTaskSource null이면 config로 Linear init(OAuth/apiKey) 후LinearTaskSource생성.openswarm auth login --provider linear' 안내.검증
requireApprove=false(revise도 파일링) + ensureTaskSource 경유 + 0건 안내. tsc/build clean, 전체 1160 green.