Skip to content

Bump DiffusionGemma #24423 pin to c3fb9724 (Add tool calling) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 1 commit into from
Jul 8, 2026
+1 −1
Merged

Bump DiffusionGemma #24423 pin to c3fb9724 (Add tool calling) #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/unsloth/pr-set.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"tag + pins), so keep its pin open until the change lands upstream."
],
"prs": [
"https://github.com/ggml-org/llama.cpp/pull/24423/commits/1d2faac2d8248c3d5df999712c42fe0fc72e7f07",
"https://github.com/ggml-org/llama.cpp/pull/24423/commits/c3fb97241295c196e09b783e705e84b96cd1bd74",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin a commit that ignores tool_choice

This updated pin pulls in c3fb972, whose only tool-calling change reads req["tools"] into the chat-template inputs but never reads tool_choice. For OpenAI-compatible requests that include tools while setting tool_choice: "none", the diffusion visual server still exposes those tools to the model, so callers cannot reliably suppress tool calls in the same way the regular server does; please pin a follow-up that handles tool_choice or avoid advertising this as the tool-calling fix until that path is covered.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve tool-call grammar from the pinned commit

The pinned c3fb972 path only uses common_chat_templates_apply(...).prompt after adding inputs.tools; it discards the grammar and grammar_lazy that common_chat_templates_apply returns and that tools/server/server-common.cpp forwards for tool requests. For tools with required fields, enums, or numeric schemas, the visual server can now render the tools but still samples unconstrained text, so callers can receive malformed or out-of-schema tool calls instead of the schema-correct calls expected from OpenAI-compatible tool use.

Useful? React with 👍 / 👎.

"https://github.com/ggml-org/llama.cpp/pull/24523/commits/00f95bd2d59ed2d6408fa3777b43ff5bd5fdc79d",
"https://github.com/ggml-org/llama.cpp/pull/25402/commits/15f732183bc1029df4b41ae2118364c3ccb6c162"
]
Expand Down