checkpoint: create checkpoint file with 0600 instead of 0644 - #44
Merged
Conversation
checkpoint_save() opened the checkpoint file with group and other read permissions. The checkpoint file contains the source and destination paths of files being transferred, which can leak information to other local users on shared systems. Restrict the mode to owner read/write only, since the file only needs to be read back by the same user during a -R resume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkpoint_save() opens the checkpoint file with group and other read permissions (0644). The checkpoint file stores the source and destination paths of files being transferred, so on a shared system other local users can read it and learn what files someone is copying. There's no reason for anyone but the owner to read this file, so restrict it to 0600.