fix(UP-2569): use latest secret version for scaler, README updated - #50
Merged
Conversation
| # picked up automatically without a terraform apply. Pinning a numeric | ||
| # version here would leave the scaler on a stale (possibly disabled) | ||
| # version after rotation, causing ObtainToken 401s. | ||
| version = "latest" |
Contributor
There was a problem hiding this comment.
can we make this a variable (so that we can more easily support version pinning in the future)
Contributor
Author
There was a problem hiding this comment.
Done, and also using the same variable for the instance templates now to avoid drift
iDaani
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version was being pinned to whatever 'latest' was at plan time. This meant that a rotated secret was never picked up - therefore the scaler failed to authenticate.
Instead use
latestexplicitly. This should pick up any rotated secret in GCP.