Convert milliseconds timestamp to seconds to compare like units#3
Open
agrymaloski wants to merge 3 commits intomainfrom
Open
Convert milliseconds timestamp to seconds to compare like units#3agrymaloski wants to merge 3 commits intomainfrom
agrymaloski wants to merge 3 commits intomainfrom
Conversation
nevi-me
approved these changes
Feb 10, 2026
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
It's convention in Python to use seconds, so this looks fine.
| continue | ||
| # ensure that we don't move the target directory to itself | ||
| if obj_id == target_id: | ||
| breakpoint() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the timestamp of drive files returned by ulsdk from milliseconds to seconds. This ensures that all time values are compared in the same unit (seconds).
ul drive mv -env stage -region us "0500c702-8685-a15e-47e9-b1c57526c651/*" 0500c287-a85e-597c-4a1d-ae8b7395e17c -start 2023-02-22 -end 2025-06-01Add check to ensure target does not move into itself.