Open
Conversation
|
I am not quite sure who is best to review this, as the author isn't at Tlon and are sigils even Tlon's or the Foundation's to handle? |
Member
Contributor
|
@thelifeandtimes we'll need to get this updated with the new version before we can merge |
Author
|
merged with master and redid the changes. I made a the translate and scale changes entirely in my head so definitely would appreciate a second set of eyes. |
Author
|
nvm, I found the nice preview tool. Sadly my npm install is borked will try to resolve and test soon. |
Contributor
|
glad to see this picked up. just giving it a glance I see you mention 16 phoneme length, but isn't that for comets not moons? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
Adds support for moon sigils on a 4x4 grid
Still needs testing