Merged
Conversation
Owner
|
@glcraft awesome!! This looks great, we'll let you know if we have any questions/comments <3 |
Signed-off-by: Gabin Lefranc <gabin.lefranc@gmail.com>
Owner
|
@glcraft apologies for updating the lint and detek rules in the middle of your PR :( |
Contributor
Author
|
I just fixed the detekt test. I took a look at the CI and I see I can't pass the gradlew lintDebug test, because I didn't translate the contentDescription for all languages (only for EN and FR). |
Signed-off-by: Urik Development <hello@urik.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a button to close the clipboard to go back to the keyboard.
Note: I was able to translate EN to FR by myself, but I cannot do the translation other than by using a translation tool.