Conversation
BohunD
commented
May 15, 2025
BohunD
commented
design/src/main/java/com/urlaunched/android/design/ui/otpContainer/models/OtpCellStyle.kt
Outdated
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/otpContainer/models/OtpCellStyle.kt
Outdated
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/otpContainer/OtpContainer.kt
Outdated
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/otpContainer/OtpContainer.kt
Outdated
Show resolved
Hide resolved
mkhotych
force-pushed
the
feature/otp
branch
from
4def22d to
c2cb806
Compare
|
design/src/main/java/com/urlaunched/android/design/ui/otptextfield/OtpTextField.kt
Outdated
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/otpcontainer/OTPContainer.kt
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/otpcontainer/OTPCellScope.kt
Outdated
Show resolved
Hide resolved
| private const val DEFAULT_OTP_LENGTH = 6 | ||
|
|
||
| @Composable | ||
| fun OTPContainerWithError( |
There was a problem hiding this comment.
А нельзя как-то контейнер перегрузить один, чтобы error был опциональной частью основного контейнера?
There was a problem hiding this comment.
Помилка не у всіх кейсах потрібна, наприклад на Wain не використовується цей overload. При цьому тоді можна буде застосувати Modifier тільки до Column, і також для помилки потрібно буде прокидувати окремо параметр з error-повідомленням і окремо isError
| } | ||
|
|
||
| @Composable | ||
| fun OTPContainer( |
There was a problem hiding this comment.
Предлагаю этот контейнер сделать private, чтобы не создавать неопределенность у разработчика, который будет это использовать
There was a problem hiding this comment.
Може додати Base приставку? Щоб якщо, то його все ж можна було використати
There was a problem hiding this comment.
Давай первую версию без Base, а если будет необходимость, то потом сделают update core-а
design/src/main/java/com/urlaunched/android/design/ui/shadow/models/ShadowStyle.kt
Show resolved
Hide resolved
| keyboardOptions = keyboardOptions, | ||
| keyboardActions = keyboardActions, | ||
| cellContent = { | ||
| OTPCellView( |
There was a problem hiding this comment.
OTPCellView -> OTPCell/OTPCellContainer
4 participants
