Created a UI component for the core DownloadingProgressDialog#112
Open
Boonapart228 wants to merge 20 commits intodevfrom
Open
Created a UI component for the core DownloadingProgressDialog#112Boonapart228 wants to merge 20 commits intodevfrom
Boonapart228 wants to merge 20 commits intodevfrom
Conversation
mkhotych
force-pushed
the
chore/download-data-dialog
branch
from
aafc9c5 to
a653a96
Compare
VMihalatiuk
reviewed
Sep 18, 2025
...ain/java/com/urlaunched/android/design/ui/downloadingProgressDialog/AdaptableProgressText.kt
Outdated
Show resolved
Hide resolved
...java/com/urlaunched/android/design/ui/downloadingProgressDialog/DownloadingProgressDialog.kt
Show resolved
Hide resolved
VMihalatiuk
reviewed
Sep 18, 2025
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressDialog.kt
Outdated
Show resolved
Hide resolved
| description: (@Composable ColumnScope.() -> Unit)? = null, | ||
| progressText: (@Composable BoxScope.(Float) -> Unit)? = null, | ||
| supportingText: (@Composable RowScope.(Float) -> Unit)? = null, | ||
| button: (@Composable ColumnScope.() -> Unit)? = null |
Contributor
There was a problem hiding this comment.
content? чи що це за button?
Collaborator
There was a problem hiding this comment.
button - це опційна кнопка яка може бути, наприклад Cancel
Collaborator
There was a problem hiding this comment.
так давайте называть bottomContent или что-то типа того, не обязательно ж button
...java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressDialog.kt
Outdated
Show resolved
Hide resolved
...java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressDialog.kt
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/progresstext/ProgressText.kt
Outdated
Show resolved
Hide resolved
VMihalatiuk
reviewed
Sep 22, 2025
design/src/main/java/com/urlaunched/android/design/ui/progresstext/ProgressText.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
VMihalatiuk
reviewed
Sep 22, 2025
...in/java/com/urlaunched/android/design/ui/downloadingprogressdialog/DownloadingProgressBar.kt
Outdated
Show resolved
Hide resolved
design/src/main/java/com/urlaunched/android/design/ui/progresstext/ProgressText.kt
Outdated
Show resolved
Hide resolved
VMihalatiuk
previously approved these changes
Oct 7, 2025
| import kotlinx.coroutines.isActive | ||
|
|
||
| @Composable | ||
| fun AnimatedDownloadingProgressBar( |
Collaborator
There was a problem hiding this comment.
- Зачем нужна дополнительная обертка? Снизу есть тоже AnimatedDownloadingProgressBar
- Давай не указывать в названии слово Animated
Collaborator
There was a problem hiding this comment.
- Цей приймає колір і перетворює його в
Brush, а той, що нижче, загальний, приймаєBrushнапряму - Як тоді розрізняти той, що з анімацією, і той то, що без?
| } | ||
|
|
||
| @Composable | ||
| fun DownloadingProgressBar( |
Collaborator
There was a problem hiding this comment.
Опять много контейнеров наружу смотрит. Разработчик должен сесть за задачу и заиспользовать контейнер, чтобы его не конфузило, какой использовать
Collaborator
There was a problem hiding this comment.
Це варіація з Brush і без анімації
| description: (@Composable ColumnScope.() -> Unit)? = null, | ||
| progressText: (@Composable BoxScope.(Float) -> Unit)? = null, | ||
| supportingText: (@Composable RowScope.(Float) -> Unit)? = null, | ||
| button: (@Composable ColumnScope.() -> Unit)? = null |
Collaborator
There was a problem hiding this comment.
так давайте называть bottomContent или что-то типа того, не обязательно ж button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.