Open
Conversation
mkhotych
force-pushed
the
chore/imagepicker
branch
from
f7c0842 to
502f5db
Compare
Collaborator
image-picker-demo.mp4 |
VMihalatiuk
reviewed
Oct 27, 2025
| import kotlinx.coroutines.launch | ||
| import java.io.File | ||
|
|
||
| class ImagePickerState( |
Contributor
There was a problem hiding this comment.
Давай ще додамо конфіг для того, щоб не відображати діалог з вибором камера чи файл, щоб можна було одразу відображати тільки файл-пікер. Я думаю, це може бути корисно в певних випадках
| var isImageCompressionProceed by mutableStateOf(false) | ||
| private set | ||
|
|
||
| fun processPickedUris(uris: List<Uri>, context: Context) { |
Contributor
There was a problem hiding this comment.
Мені здається, що цей метод має бути приватним
| } | ||
| } | ||
|
|
||
| fun processPickedFiles(files: List<File>, context: Context) { |
Comment on lines
+104
to
+105
| photoTooLargeErrorMessage: String, | ||
| compressionErrorMessage: String, |
Contributor
There was a problem hiding this comment.
Я не бачу сенсу створювати ще один overload з параметрами, які фактично не використовуються в стейті, а просто повертаються в тому ж колбеці showErrorSnackbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.