feat(ac-store): salvage ACs from closed PRs #113 and #1 (BO-2000, TQ-200)#238
Open
urlmonitor wants to merge 1 commit into
Open
feat(ac-store): salvage ACs from closed PRs #113 and #1 (BO-2000, TQ-200)#238urlmonitor wants to merge 1 commit into
urlmonitor wants to merge 1 commit into
Conversation
Re-authors the genuinely-valuable content from two closed-as-unmergeable PRs under fresh, collision-free AC IDs via the PO v3 -> BA v3 -> IT PO v3 flow. BO-2000-self-protecting-build (from #113, which collided on the reassigned BO-1500 id): - BO-2000a (KI-2): self-hosting non-regression claims must be backed by a recorded command + captured zero-new-violations output; bare 'verified' claims are rejected by the AC-fulfillment gates. - BO-2000b (KI-3): builds must never run over an active worktree root; deploy is exercised against a disposable --target-dir outside the worktree. TQ-200-tooling-coverage-recovery (from #1): recover unit-test coverage for 9 currently-untested package-internal tooling modules (registry_validator, package_audit, selection_criteria_evaluator, injection/template_compiler, generate_agent_diagram, prioritize, scan_secrets). All ACs are readiness: draft (queued for review; will not auto-build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-authors the genuinely-valuable content from two PRs that were closed as unmergeable (stale, conflicting, and colliding on reassigned AC IDs), under fresh collision-free IDs via the canonical PO v3 → BA v3 → IT PO v3 flow (ADR-012).
All ACs are
readiness: draft— queued for review; they will not be picked up by/build-acuntil promoted toapproved.BO-2000-self-protecting-build (salvages #113)
Original #113 collided on the reassigned
BO-1500id. Re-authored as a newBO-2000tree, explicitly disambiguated from BO-1700 (hook execution in worktrees) and BO-1500 (safe AC-authoring delivery):--target-diroutside the worktree; dual-tree files are edited intemplates/and compared, never build-synced.TQ-200-tooling-coverage-recovery (salvages #1)
Recovers unit-test coverage for 9 currently-untested package-internal tooling modules:
registry_validator(core + spawn bidirectionality), registry injection (injection_builders+template_compiler),package_audit,selection_criteria_evaluator,generate_agent_diagram,prioritize,scan_secrets.Several TQ-200 L2 criteria describe behavior that does not exist in the current code — decide whether to amend to pure coverage-recovery or expand scope:
prioritize.pyhas no parked-ticket handling (_is_doneonly knows done/deferred).registry_validatorhas no missing-field / duplicate-id validation (missingidraises KeyError).selection_criteria_evaluatorDSL has no negation operator.And for BO-2000a: the evidence-bundle location is unspecified (sign-off comment vs. artifact file vs. AC field) — needs a BA decision before the gate rule can be written.
Test plan
check_ac_schema.py, exit 0).covered_bylists wired.🤖 Generated with Claude Code