docs: fast-lane review lessons — grep-tests hide phantom-done; deploy-manifest completeness#384
Merged
Merged
Conversation
… deploy-manifest completeness)
Two CLAUDE.md Implementation-Conventions entries distilled from the fast-lane build + independent code-review/logic-check: (1) gate/workflow ACs must be verified behaviorally or by semantic-consumption, never grep-only string presence — the anti-phantom-done feature itself shipped a phantom-done runner that passed grep tests while never executing its gates. (2) a new module imported by a commit-guardian hook / required CI gate must be added to the build deploy_map or the deployed hook crashes with ModuleNotFoundError and blocks every merge once required. Also commits the IT-PO greenfield package-surface assignment note (memory/) surfaced during the run. SKIP=check-product-truth-{validate,generate}: pre-existing unrelated index drift.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures two hard-won lessons from building the fast-lane feature and its independent review, as CLAUDE.md Implementation-Conventions entries (matching the existing retro-KI style):
Gate/Workflow ACs — verify behaviorally, not by grep. The anti-phantom-done feature itself shipped a phantom-done runner:
fast-lane-build.jspassed its grep-only structural tests while never executing its gates, andfast_lane.pyhad no CLI (itsselect_batchcall was a no-op). Invisible to structural tests; caught only by a code-review agent + a logic-check agent that executed the code. Rule: cover workflow/gate ACs with behavioral or semantic-consumption tests + independent adversarial review before marking done.New hook/gate deps must be in the build deploy-manifest.
done_proof.py(backing thecheck_done_proofhook + the required CI done-proof gate) was omitted frombuild_ac_store'sdeploy_map, so the deployed hook crashed withModuleNotFoundError— which would have blocked every merge once the gate became required. Rule: add hook/gate imports to the deploy_map and verify via the deployed hook, not just source-tree unit tests.Also commits the IT-PO greenfield package-surface assignment note (
memory/) surfaced during the run.Separate from the fast-lane feature PR (#378) — this is pure knowledge capture.
🤖 Generated with Claude Code