specific tag for deploy container image as per branch

[prashantpandeygit]

Fixes #283

Enabled branch specific container image tags for urunc-deploy, removed the hardcoded latest tag, with this it is easy to deploy and test with versions.

Changes

added images field so that override can be done on the tag,
script to get tag from the git state. (also, the tag remains :latest as default, making backward compatible)

Tests

getting the tag:

kustomize build on urunc-deploy (same for cleanup):

set the tag:

verifying through build:

[netlify]

✅ Deploy Preview for urunc ready!

Name	Link
🔨 Latest commit	4804135
🔍 Latest deploy log	https://app.netlify.com/projects/urunc/deploys/6979f3b8dd4a3100089b04c9
😎 Deploy Preview	https://deploy-preview-386--urunc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[prashantpandeygit]

@ananos @cmainas have a look please when you get a moment. thanks!

[cmainas]

Hello @prashantpandeygit ,

thank you for this PR. Unfortunately, these changes do not resolve correctly the referenced issue:

• There is no reason for a script to obtain the current tag/hash.
• We should also update the respective documentation to also include the necessary steps to specify the version of urunc-deploy to use.
• The changes do not resolve the first point of the issue

When we push a new commit to main, we should be able to calculate the commit hash of the current tip of main, and use this as the tag to the container image built and pushed using the automated action.

[prashantpandeygit]

thanks for the review @cmainas , my bad i interpreted the issue that the tag should be overridden by using script as it was mentioned.

so we need to make changes to the CI so that the tag gets automatically updated when a new image is built? is there something more that would help making these changes? thanks!

[prashantpandeygit]

I tried to work around and i guess this must work, i could only test the tag changing locally.

also used sed to change string, that must not create issue as we are on ubuntu 22.04

and took the identity from pr-takeover.yml, hope that is correct

will add docs if this approach is fine

[cmainas]

I think there is a misunderstanding. The #283 states that we should calculate the commit hash and use it as a tag for the container image that we build, not deploy. Then it is up to the user to specify the correct tag when using the urunc-deploy method. For that part, we can simply document the method to do that (either with sed or anything else).

[prashantpandeygit]

@cmainas the issue had the statement with deploy, so I thought we might need to deploy with changing the tag too, i understood it wrong.
so now is there anything apart from changing the documentation? I'll just include doc on how to manually change the image tag (clone repo and update tag) and remove the CI changes i made, could you just tell this is correct as i don't want to be wrong again? thanks!

[cmainas]

@cmainas the issue had the statement with deploy, so I thought we might need to deploy with changing the tag too, i understood it wrong. so now is there anything apart from changing the documentation? I'll just include doc on how to manually change the image tag (clone repo and update tag) and remove the CI changes i made, could you just tell this is correct as i don't want to be wrong again? thanks!

Hello @prashantpandeygit , it is not just the documentation. We need to update the tag we use when we build the urunc-deploy container image. Currently, we use the latest tag for all urunc-deploy images we build when we push changes in the main branch. We need to change this and use two tags, latest and one more that we calculate based on the current commit hash.

[prashantpandeygit]

now we are building the image with 2 tags and have added the documentation on how user can use the correct tag for deployment