Fix cgroups #399
Open
Fix cgroups #399
+993
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement cgroup v2 management for urunc containers using a split-policy architecture that separates vCPU (workload) threads from I/O (overhead) threads. Key changes: - Introduce pkg/cgroup/manager.go with a Manager handling cgroup lifecycle - Initialize cgroups during container creation via setupCgroups() in create.go - Move the runtime process to the overhead cgroup before exec - Move vCPU threads to the workload cgroup after a 200ms delay in start.go - Add cgroup configuration support in urunc_config.go - Add unit tests for cgroup manager behavior Signed-off-by: Panos Mavrikos <pmavrikos@nubificus.co.uk>
✅ Deploy Preview for urunc canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cgroup v2 management for urunc containers using a split-policy
architecture that separates vCPU (workload) threads from I/O (overhead) threads.
Changes
How it works
The pre-move pattern ensures proper thread classification without a helper process:
Final state: vCPU threads are in SANDBOX (with resource limits), while QEMU main
process and I/O threads remain in OVERHEAD (no limits).