Campaign - #2143
Open
Parvinmh wants to merge 22 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Parvinmh is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
binrysearch
reviewed
Nov 29, 2025
| * Resume idle timers when page becomes visible | ||
| */ | ||
| private resumeIdleTimers(): void { | ||
| // Implementation for resuming idle timers |
Contributor
There was a problem hiding this comment.
These need to be implemented I assume?
| updatedAt?: string; | ||
| author?: string; | ||
| tags?: string[]; | ||
| priority?: number; // Priority for when multiple campaigns match (higher = higher priority) |
Contributor
There was a problem hiding this comment.
Is this currently implemented?
| if (this.isInitialized) return; | ||
|
|
||
| // Track session count | ||
| const sessionCountKey = "introjs-campaign-session-count"; |
Contributor
There was a problem hiding this comment.
This needs to be in configs.
| updateStatus('Initializing campaigns from JSON file...'); | ||
|
|
||
| // Initialize campaigns from JSON file (correct path for this directory) | ||
| await introJs.initializeCampaigns("./campaigns/first-visit-tour.json"); |
Contributor
There was a problem hiding this comment.
How this would work in a browser environment? How do we do file I/O when running in browser context?
…ation and mouseout cancel
…ouble-incremented
…nd missing minVisits
…sensitivity config
…rm-level selectors
…ement on short pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.