Feat/floating UI positioning - #2161
Open
Parvinmh wants to merge 17 commits into
Open
Conversation
|
@Parvinmh is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offset,flip, andshiftare now composable middleware factories — same mental model as floating-uicomputePosition()instead of customcheckLeft/checkRight/alignTooltipfunctionsshiftnudges the tooltipWhat changed
New:
src/packages/positioning/index.tsA standalone positioning engine with a middleware pipeline:
offset(value)— gaps the floating element from the reference along main/cross axesflip(options)— switches to the best available placement when the primary one overflows; uses aresetmechanism sooffsetre-applies on the new placementshift(options)— nudges the floating element to stay within the viewport when flip alone isn't enoughcomputePosition()— runs the pipeline, returns CSS-readyx/yplus viewport-relative coords for overflow checksautoUpdate()— re-runs position on scroll, resize, and ResizeObserverChanged:
tooltip.tsandhint/position.tsBoth now delegate entirely to
computePosition(). The old manual geometry (checkLeft,checkRight,alignTooltip,alignHintPositionswitch/case) is gone.New:
tooltipArrow.tsExtracted from
tooltip.ts.computeArrowStyles()corrects the arrow's CSS position whenshifthas moved the tooltip, so the arrow keeps pointing at the reference element.Removed:
tooltipPosition.ts+ its testsdetermineAutoPositionanddetermineAutoAlignmentwere fully replaced by theflipmiddleware and are no longer needed.