Skip to content

[desktop] Fix module-level state and silent failure in caret plugin #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
usamaasfar merged 2 commits into from
Feb 21, 2026
Merged

[desktop] Fix module-level state and silent failure in caret plugin #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e6516
Initial plan
Copilot Feb 21, 2026
ba5fb5b
Fix module-level state and silent failure in caret plugin
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions apps/desktop/src/editor/plugins/caret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@ import type { EditorView } from "prosemirror-view";
export type CaretStyle = "line" | "underline";

let caretStyle: CaretStyle = (localStorage.getItem("cursor") as CaretStyle) ?? "line";
let activeView: EditorView | null = null;
let activeEl: HTMLElement | null = null;

// Track all active caret instances so setCaretStyle updates every editor.
const activeInstances = new Map<EditorView, HTMLElement>();

export function setCaretStyle(style: CaretStyle) {
caretStyle = style;
if (activeView && activeEl) updateCaret(activeView, activeEl);
for (const [view, el] of activeInstances) {
updateCaret(view, el);
}
}

function getCursorRect(view: EditorView) {
Expand Down Expand Up @@ -48,12 +51,19 @@ function updateCaret(view: EditorView, el: HTMLElement) {

export const caretPlugin = new Plugin({
view(view) {
const parent = view.dom.parentElement;
if (!parent) {
throw new Error(
"caretPlugin: editor DOM node has no parent element – ensure the editor is mounted in the DOM before initializing the caret plugin",
);
}

const el = document.createElement("div");
el.className = "pm-caret";
el.setAttribute("data-style", caretStyle);
view.dom.parentElement?.appendChild(el);
activeView = view;
activeEl = el;
parent.appendChild(el);

activeInstances.set(view, el);
updateCaret(view, el);

return {
Expand All @@ -62,8 +72,7 @@ export const caretPlugin = new Plugin({
},
destroy() {
el.remove();
activeView = null;
activeEl = null;
activeInstances.delete(view);
},
};
},
Expand Down