feat & fix: lists plugin bug fixes & backward unformatting step feature#15
Open
diamondniam wants to merge 6 commits intouse-kona:devfrom
Open
feat & fix: lists plugin bug fixes & backward unformatting step feature#15diamondniam wants to merge 6 commits intouse-kona:devfrom
diamondniam wants to merge 6 commits intouse-kona:devfrom
Conversation
eden-lane
reviewed
Aug 19, 2025
| listItemType = ListsPlugin.LIST_ITEM_ELEMENT, | ||
| defaultType = "paragraph" | ||
| ) => { | ||
| function isList(node: CustomElement) { |
Member
There was a problem hiding this comment.
I don't think we need this function, because we have static isList function inside of a class
| at: prevListItemPath, | ||
| match: (n) => this.isListItem(editor, n as CustomElement), | ||
| match: (n) => { | ||
| console.log( |
Member
There was a problem hiding this comment.
We need to get rid of debugging only console logs
| at: range, | ||
| match: (n) => { | ||
| return Element.isElement(n) && n.type === listItemType; | ||
| return Element.isElement(n) && n.type === defaultType; |
Member
There was a problem hiding this comment.
As far as I understood this code, we're converting only defaultType elements to the list. What if I want to convert a heading into the list? I think this code won't work
Contributor
Author
|
you are right. sorry for the misses. will fix it |
Member
@diamondniam no worries at all! |
1. backward unformatting feature for lists, 2. clean functionality for nested formattings and unformattings, 3. bug fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.