in calc_sum added needs.values() as parameter to filter_single_need()#1453
Open
PhilipPartsch wants to merge 4 commits intouseblocks:masterfrom
Open
in calc_sum added needs.values() as parameter to filter_single_need()#1453PhilipPartsch wants to merge 4 commits intouseblocks:masterfrom
PhilipPartsch wants to merge 4 commits intouseblocks:masterfrom
Conversation
Contributor
Author
|
@ubmarco, @danwos , @chrisjsewell : Could I get a review? |
chrisjsewell
reviewed
Nov 8, 2025
Member
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
Heya, I would need to see a good use case of why this is required cheers
Contributor
Author
|
The Idea is to have the same filter algorithm as for needtable, needlist, ... |
Contributor
Author
|
Even the documentation specifies, we can use So the missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to implement #1452