🛠️ Refactor Sphinx-Needs DataTables integration to use GridJS#1464
🛠️ Refactor Sphinx-Needs DataTables integration to use GridJS#1464
Conversation
There was a problem hiding this comment.
Looks already promising.
After building the official docs I found some problems:
-
Pagination works fine, but we need an option how much elements shall be shown: 10, 25, 50, All.
Otherwise dealing with big tables will not be so comfortable. -
The sticky head is a nice idea.
But it is confusing, as the header is transparent so that it shows row data as well:

-
If possible, let's remove the icons, as they may not match a specific theme and their look-alike depends on os/browser:

|
Here is a comparison of both.
The goal is to have the table data itself quite prominent, but all buttons and co. in a less prominent style. But that's it, the diffs are already not so much. |
|
@chrisjsewell what do you think? |
|
Another finding: Row style seems not to work
|
…ination limit selector, and enhance language settings




Changes for issue #122:
Motivation for this change:
Our used DataTables version is quite old (>~4 years) and is still based on jQuery, which was also removed from Sphinx some long time ago.
Also, the JS world has changed, docs get presented in React/Angular/Svelte apps, in which DataTables is causing some problems or at least is adding some unnecessary dependencies (jQuery).
Therefore, this PR cleans up our used JS environment and feels more modern now.