🧪 Add additional fixture tests for schemas#1648
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 86.87% 88.80% +1.92%
==========================================
Files 56 70 +14
Lines 6532 9988 +3456
==========================================
+ Hits 5675 8870 +3195
- Misses 857 1118 +261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| validate: | ||
| network: | ||
| links: | ||
| tests: |
There was a problem hiding this comment.
The 2 newly added tests in this file essentially test the same, just for different config data.
Additional properties are not allowed ('derived_from' was unexpected)
Additional properties are not allowed ('tests' was unexpected)
This does not look like the initial goal when reading the message fields:
Schema that mixes network.links and direct network.<type> - MUST be rejected
impl must derive from spec and be tested
Any children under network is always a link type, so there is no such thing as network.links. network.<link-type> makes more sense.
Maybe I miss something.
| :status: approved | ||
|
|
||
| # Test: Core fields with defaults should be reduced away | ||
| # This validates that title/status/tags are reduced when they have default values |
There was a problem hiding this comment.
Technically, title is not on default, it is set to My Title.
It is reduced away because it is not part of the schema properties.
| :id: IMPL_1 | ||
| :links: SPEC_1 | ||
|
|
||
| # Test: Schema properties whitelist - keep field only if in schema |
There was a problem hiding this comment.
This actually tests something different. priority is an extra field.
It is still there because it is not None.
2 participants
No description provided.