Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to resolve #123
However, let me add to the description of the issue above that it also applies to internal references inside the PDF, hence, currently
:ref:or:numref:are not working for sub-headlines in any case.The suggested changes here, should fix the issue for both the HTML and the PDF.
What does my solution do:
###is present in the link, as it basically doen't modify the link in such cases)If anyone has a better solution, which I assume are possible, as I'm not all that familiar with this project, please suggest them.
It would be nice, if this could be resolved soon, thank you :)