Open
Conversation
Backend: - Cookie IPC handlers: delete, add, modify, parse, create cookie string - Broadcast cookies-update to webviews after request execution - Register handlers in extension activation Frontend: - Mount StatusBar in Bruno page layout (was defined but never rendered) - Remove DevTools, Search, Notifications from status bar (VS Code native) - Resize cookies modal to md - Add data-testid attributes to cookie UI components Testing: - Vitest + vscode mock setup - 9 unit tests for cookie jar operations - 2 Playwright e2e tests (empty state, cookie capture from response) - Local test server with cookie auth endpoints
chirag-bruno
force-pushed
the
feature/cookies
branch
from
7bdc4de to
a852b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full cookie management support to the VS Code extension, bridging the existing Cookie UI to the @usebruno/requests cookie jar.
Changes
Backend:
src/extension/ipc/cookie-handlers.ts— IPC handlers for all cookie operationssrc/extension/ipc/network/index.ts— Broadcastmain:cookies-updateafter response cookies are capturedsrc/extension/extension.ts— Register cookie handlers on activationFrontend:
src/webview/pages/Bruno/index.tsx— Mount StatusBar componentsrc/webview/components/StatusBar/index.tsx— Remove VS Code-native items (DevTools, Search, Notifications)src/webview/components/Cookies/index.tsx— Add data-testid attributes, resize modalsrc/webview/components/Cookies/ModifyCookieModal/index.tsx— Add data-testid to form fieldsTesting:
src/extension/ipc/cookie-handlers.spec.ts— 9 unit tests for cookie jar operationstests/e2e/specs/cookies.spec.ts— 2 e2e tests (empty state, cookie capture)tests/e2e/server/auth/cookie.ts— Cookie auth endpoints (login, logout, protected, set, echo)Test plan
npm test— 9 unit tests passnpm run test:e2e -- --grep Cookie— 2 e2e tests passnpm run build— extension builds