chore: remove the Roslyn integration#8
Merged
Conversation
The docs site migrated off Roslyn to the reflection-based API metadata provider (AddApiMetadataFromCompiledAssembly) plus TreeSitter :symbol fences, so Pennington.Roslyn is now redundant. - Delete src/Pennington.Roslyn, tests/Pennington.Roslyn.Tests, and the examples/BeyondRoslynExample example (incl. its Sample/ library). - Drop those projects from Pennington.slnx/.slnf and remove the 7 Roslyn-only package versions from Directory.Packages.props (keep DiffPlex, shared with TreeSitter, and MetadataLoadContext). - Remove the vestigial Roslyn project reference and two obsolete skipped tests from Pennington.IntegrationTests. - Land the reflection inheritdoc / record-param resolvers and tests that bring the compiled-assembly backend to parity. - Scrub every Roslyn / :xmldocid reference from docs content, examples, READMEs, CLAUDE.md files, and code comments; delete the connect-roslyn tutorial and repoint dangling xrefs to the reflection / :symbol forms. Verified: dotnet build (0/0), dotnet test (all pass), and the static docs build (457 pages, no broken-xref diagnostics).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The docs site already migrated off Roslyn to the reflection-based API metadata provider (
AddApiMetadataFromCompiledAssembly) and TreeSitter:symbolfences. Nothing in the core library depends onPennington.Roslyn— it is purely opt-in — so the package, its tests, its example, and every doc/prose/comment reference to it are now dead weight. We have not shipped, so this is the moment to drop it.What changed
Deleted
src/Pennington.Roslyn/(highlighter,:xmldocid/:pathpreprocessor, Roslyn API-metadata provider)tests/Pennington.Roslyn.Tests/examples/BeyondRoslynExample/(incl. itsSample/library)XmlDocIdFenceSweepSmokeTest,ApiReferenceComponentTests) that targeted a deleted type on a draft pageWiring
Pennington.slnx/Pennington.slnfDirectory.Packages.props(keptDiffPlex, shared with TreeSitter, andMetadataLoadContext, used by the reflection backend)Pennington.Roslynreference fromPennington.IntegrationTestsReflection backend
ReflectionInheritDocResolver/ReflectionRecordParamFallbackresolvers and tests that bring the compiled-assembly backend to parity (the replacement this removal depends on)Docs & prose
connect-roslyntutorial and repointed every danglingxref/link to the reflection /:symbolequivalentsfocused-code-samples.mdand the highlighting explanation onto TreeSitter:symbol; trimmedauto-api-reference.mdto the reflection backendllms.txt, the homepage, READMEs,CLAUDE.mdfiles, and code commentsVerification
dotnet build Pennington.slnx— 0 warnings, 0 errorsdotnet test Pennington.slnx— all pass (806 + 48 + 40)dotnet run --project docs/Pennington.Docs -- build— exit 0, 457 pages, no broken-xref/diagnostic outputRoslyn(excl.bin/obj/artifacts, incl..github) — zero hitsNote
examples/AUDIT_LOG.mdis a dated historical log; I removed the deleted example's audit section (which carried theRoslynreferences) but left other dated entries' incidental:xmldocidmentions intact rather than rewrite history. Easy to scrub those too if preferred.