feat: add opt-in completion nudge#729
Open
0xhis wants to merge 2 commits into
Open
Conversation
0xhis
force-pushed
the
feat/completion-nudge
branch
from
July 10, 2026 22:05
b6ee501 to
503a610
Compare
0xhis
marked this pull request as ready for review
July 10, 2026 22:09
Contributor
Greptile SummaryThis PR adds an opt-in completion nudge before accepting the final scan report. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "docs: describe completion nudge" | Re-trigger Greptile |
0xhis
force-pushed
the
feat/completion-nudge
branch
2 times, most recently
from
July 10, 2026 22:18
aa4b8ce to
99f7dc2
Compare
0xallam
force-pushed
the
main
branch
3 times, most recently
from
July 13, 2026 23:50
44e87ca to
daf39a2
Compare
0xallam
force-pushed
the
feat/completion-nudge
branch
from
July 14, 2026 00:00
99f7dc2 to
6b97de2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--completion-nudgegives the root agent one more pass before it finalizes a scan.Some models, especially OSS models like Hy3, can spot a promising lead and then finish the report before they really poke at it. With this flag, the first
finish_scanbecomes a draft. The same agent gets a single prompt to follow up on leads it found and check remaining untested areas. Its next valid report finishes the scan.Details
run.jsonand preserved by--resume.Completion nudgedwhile the scan continues.Tests
Added coverage for the flag, resume behavior, the one-time coordinator state, first and second
finish_scancalls, invalid reports, active children, coordinator-less calls, and CLI/TUI rendering.The focused feature and regression suite passed with 30 tests. Ruff and focused mypy/pyright checks also passed.
Live run
I ran it against OWASP Juice Shop with
--completion-nudge.The agent submitted its first report, got the nudge, and continued in the same session. It followed up on the leads it had left open, filed one more validated finding, then completed normally with 13 findings.