Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/llm-providers/vertex.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ export VERTEXAI_LOCATION="global"
## Prerequisites

1. Enable the Vertex AI API in your Google Cloud project
2. Ensure your account has the `Vertex AI User` role
2. Ensure your account has the `Agent Platform User` role (`roles/aiplatform.user`)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Vertex Role Name Mismatch

This page is for the Vertex AI provider, but the prerequisite now leads with Agent Platform User. A user searching IAM by that display name during Vertex AI setup may miss the expected Vertex AI User role and choose a broader role instead, even though the role ID is correct.

Suggested change
2. Ensure your account has the `Agent Platform User` role (`roles/aiplatform.user`)
2. Ensure your account has the `Vertex AI User` role (`roles/aiplatform.user`)
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/llm-providers/vertex.mdx
Line: 53

Comment:
**Vertex Role Name Mismatch**

This page is for the Vertex AI provider, but the prerequisite now leads with `Agent Platform User`. A user searching IAM by that display name during Vertex AI setup may miss the expected `Vertex AI User` role and choose a broader role instead, even though the role ID is correct.

```suggestion
2. Ensure your account has the `Vertex AI User` role (`roles/aiplatform.user`)
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Use Vertex role name The role ID roles/aiplatform.user is correct, but the display name shown here can send users to the wrong IAM search term. In the Vertex AI setup flow, users searching by role name need Vertex AI User; searching for Agent Platform User can return no matching role even though the ID points to the right permission set.

Suggested change
2. Ensure your account has the `Agent Platform User` role (`roles/aiplatform.user`)
2. Ensure your account has the `Vertex AI User` role (`roles/aiplatform.user`)
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/llm-providers/vertex.mdx
Line: 53

Comment:
**Use Vertex role name** The role ID `roles/aiplatform.user` is correct, but the display name shown here can send users to the wrong IAM search term. In the Vertex AI setup flow, users searching by role name need `Vertex AI User`; searching for `Agent Platform User` can return no matching role even though the ID points to the right permission set.

```suggestion
2. Ensure your account has the `Vertex AI User` role (`roles/aiplatform.user`)
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!