Open
Conversation
Author
|
We actually did a much better design of this same idea, focused around rootfs tars instead of existing containers. If anyone is considering this then let's chat before you merge I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this repo hasn't changed in a long time but it'd be nice to push these changes upstream if you still want to maintain it. There's a few things that this adds:
mitchellh/packertohashicorp/packerfor Packer v1"clone_container" will copy a given LXC container instead of creating a new one and work off of that. It saves us a lot of time in a multi-stage build process for our VM images.
I think the most contentious part is the vendor stuff. I couldn't find another way to get it working though. The data structures used from latest version of
multistepandmapstructurearen't compatible with the vendored versions for whatever reason.