gamefix: More fallout game fixes

[unbelievableflavour]

Description

More fallout versions, more registry fixes

Recording

https://discord.com/channels/1378308569287622737/1491156246940618835

Checklist

• If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
• I have attached a recording of the change.
• I have read and agree to the contribution guidelines in CONTRIBUTING.md.

---

Summary by cubic

Add Steam registry fixes for Fallout 3 GOTY (22370) and Fallout: New Vegas (22490). Reordered Steam fixes (including STEAM_Fix_400, STEAM_Fix_752580, STEAM_Fix_3373660) to improve detection.

• Bug Fixes
  • 22370: create Software\Wow6432Node\Bethesda Softworks\Fallout3 with default "Installed Path".
  • 22490: create Software\Wow6432Node\Bethesda Softworks\FalloutNV with default "Installed Path".

^{Written for commit 6c723f6. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Added compatibility fixes for two additional Steam titles to improve detection and populate a sensible default installation path.
• Chores
  • Reorganized the Steam fixes registry to include the new entries and adjust ordering for more reliable matching and lookup behavior.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bf669c7-0cc0-4687-9867-be769ead6eab

📥 Commits

Reviewing files that changed from the base of the PR and between cd39c06 and 6c723f6.

📒 Files selected for processing (3)

• app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
• app/src/main/java/app/gamenative/gamefixes/STEAM_22370.kt
• app/src/main/java/app/gamenative/gamefixes/STEAM_22490.kt

✅ Files skipped from review due to trivial changes (1)

• app/src/main/java/app/gamenative/gamefixes/STEAM_22370.kt

🚧 Files skipped from review as they are similar to previous changes (2)

• app/src/main/java/app/gamenative/gamefixes/STEAM_22490.kt
• app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt

---

📝 Walkthrough

Walkthrough

Added two new Steam registry-based game fixes (gameId 22370 and 22490) and updated the Steam fixes ordering in GameFixesRegistry, inserting STEAM_Fix_400 and repositioning several Steam entries.

Changes

Cohort / File(s)	Summary
New Steam registry fixes app/src/main/java/app/gamenative/gamefixes/STEAM_22370.kt, app/src/main/java/app/gamenative/gamefixes/STEAM_22490.kt	Added STEAM_Fix_22370 and STEAM_Fix_22490 as public KeyedGameFix values created via KeyedRegistryKeyFix for GameSource.STEAM, targeting Bethesda Wow6432Node registry paths and providing defaultValues with INSTALL_PATH_PLACEHOLDER.
Registry list updates app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt	Modified the internal fixes list: inserted/repositioned Steam entries including STEAM_Fix_400, STEAM_Fix_22370, and STEAM_Fix_22490, shifting order of subsequent Steam items; mapping via associateBy { it.gameSource to it.gameId } remains.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(): silent hill 4 reg fixes #926: Adds new top-level KeyedGameFix entries and updates GameFixesRegistry in a similar pattern.
• Additional game registry fixes #608: Introduces KeyedRegistryKeyFix/KeyedGameFix types and many registry-based Steam/Epic/GOG fixes used by these entries.
• Added launch argument gamefixes #930: Also modifies GameFixesRegistry and reorders Steam fix entries, overlapping registry ordering changes.

Suggested reviewers

• phobos665

Poem

🐰
I hopped through registry rows tonight,
Two tiny fixes tucked in tight,
Paths placed where launchers used to roam,
A pocketed patch to lead them home,
I nibble bugs and sleep delight 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'gamefix: More fallout game fixes' directly and clearly summarizes the main change—adding game fixes for additional Fallout versions.
Description check	✅ Passed	The pull request description includes a clear description of changes, a recording link, and a completed checklist with all required items marked. All template sections are present and adequately filled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/java/app/gamenative/gamefixes/STEAM_22370.kt`:
- Around line 8-15: The new KeyedGameFix instances STEAM_Fix_22370 and
STEAM_Fix_22490 are defined but not added to the registry; open
GameFixesRegistry (the fixes list) and add STEAM_Fix_22370 and STEAM_Fix_22490
to the fixes collection so they will be applied at runtime (ensure the names
match the declarations in STEAM_22370.kt and STEAM_22490.kt and maintain the
list's ordering/formatting conventions).

In `@app/src/main/java/app/gamenative/gamefixes/STEAM_22490.kt`:
- Around line 8-15: Add the newly defined fix symbol STEAM_Fix_22490 to the
central registry so it will be applied at runtime: open GameFixesRegistry (the
collection where fixes are listed) and append STEAM_Fix_22490 to the fixes
list/array that currently contains other Steam fixes (the block around lines
19-39), ensuring the entry matches the existing list formatting and is
exported/visible from GameFixesRegistry so the registry includes this
KeyedGameFix.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f0a66eb-fdd5-453c-b93e-d19344dfa8a7

📥 Commits

Reviewing files that changed from the base of the PR and between f5200c5 and cdbfb99.

📒 Files selected for processing (2)

• app/src/main/java/app/gamenative/gamefixes/STEAM_22370.kt
• app/src/main/java/app/gamenative/gamefixes/STEAM_22490.kt

[cubic-dev-ai]

No issues found across 2 files

[phobos665]

LGTM.