Simplify settings screen copywriting#1175
Open
jerryjappinen wants to merge 5 commits intoutkarshdalal:masterfrom
Open
Simplify settings screen copywriting#1175jerryjappinen wants to merge 5 commits intoutkarshdalal:masterfrom
jerryjappinen wants to merge 5 commits intoutkarshdalal:masterfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoves multiple subtitle composables and a header decoration from the settings UI, repositions the Steam download server link, trims string resources and wording, and adjusts the Wine debug channel subtitle to join entries with a comma plus space. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/src/main/res/values/strings.xml (1)
446-446: Plan a follow-up localization sync for updated English strings.The base copy changed in several keys, so a translation refresh would prevent wording drift across non-English locales.
Also applies to: 782-782, 788-788, 816-816, 818-818, 825-825, 859-859, 861-861, 864-864
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/res/values/strings.xml` at line 446, Update the localization process to refresh translations for any changed base English strings—specifically ensure a translation-sync is scheduled for the updated keys such as settings_save_logcat_subtitle and the other modified string resource keys (the ones flagged in the review comment) so non-English locales receive the new wording; run your usual localization export/import workflow (or notify translators) to regenerate .xml translations and verify the updated English-to-localized mappings are applied project-wide.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@app/src/main/res/values/strings.xml`:
- Line 446: Update the localization process to refresh translations for any
changed base English strings—specifically ensure a translation-sync is scheduled
for the updated keys such as settings_save_logcat_subtitle and the other
modified string resource keys (the ones flagged in the review comment) so
non-English locales receive the new wording; run your usual localization
export/import workflow (or notify translators) to regenerate .xml translations
and verify the updated English-to-localized mappings are applied project-wide.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3c4303fc-2a52-440f-8143-e24a3b36fb54
📒 Files selected for processing (6)
app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupDebug.ktapp/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.ktapp/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInfo.ktapp/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.ktapp/src/main/java/app/gamenative/ui/screen/settings/SettingsScreen.ktapp/src/main/res/values/strings.xml
💤 Files with no reviewable changes (3)
- app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInfo.kt
- app/src/main/java/app/gamenative/ui/screen/settings/SettingsScreen.kt
- app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupEmulation.kt
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a very "conservative" PR with focus on minor copywriting aspects to clean up clutter in the settings screen, and making it easier to scroll, glance and navigate.
A couple of subtitles in the settings screen have been removed to decrease clutter in the settings screen. This should spotting their titles easier, and proper nouns like Box64 and FEXCore stand out better.
No information has really been lost, especially where a dialog still contains further details (like Driver Manager). People tend to scan titles and ignore additional descriptions anyway.
A couple of the text descriptions have been shortened. The decorative settings icon at the top has also been removed, because it looks a bit like a button but isn't one, and isn't really needed either.
I moved the external storage option below "Steam Download Server". The former is often disabled, and can expose additional options, so it's more natural to have it as the last menu item of the group.
Other notes
values/strings.xml, but I did NOT touch translationsRecording
gamenative-settings.mp4
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Simplifies the settings screen language and layout to reduce clutter and improve scanability. Removes redundant subtitles, cleans the header, tightens labels, and makes the download server setting service-agnostic while keeping it above External storage.
strings.xml(e.g., “Custom Wine/Proton versions”, “Open links in external browser”); removed unused strings.Written for commit affad69. Summary will update on new commits.
Summary by CodeRabbit
UI Improvements
Documentation / Text