fix: preserve aspect-correct viewport for screen effects

[xXJSONDeruloXx]

Description

prevents screen effects from incorrectly altering aspect ratio when applied, fix up from internal and external resolution decouple with FSR work

Recording

Checklist

• If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
• I have attached a recording of the change.
• I have read and agree to the contribution guidelines in CONTRIBUTING.md.

---

Summary by cubic

Preserves the aspect-correct viewport when screen effects are enabled. Marks the viewport as dirty so the renderer restores the scene viewport each frame and non-scaling effects no longer stretch to the full surface.

• Bug Fixes
  • In EffectComposer.render(), call renderer.setViewportNeedsUpdate(true) after binding the scene FBO and setting glViewport, so GLRenderer.drawScene() reapplies the aspect-correct viewport after effect passes override it.
  • Fixes stretching with non-scaling effects (CRT/NTSC/Vivid).

^{Written for commit c060ba7. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved viewport handling during scene rendering to ensure proper display updates in the graphics pipeline.

[coderabbitai]

📝 Walkthrough

Walkthrough

A single-line addition to EffectComposer.render() explicitly marks the renderer's viewport as needing an update immediately after binding the scene framebuffer and setting the viewport. This ensures viewport synchronization during scene rendering setup.

Changes

Cohort / File(s)	Summary
Viewport Update Timing app/src/main/java/com/winlator/renderer/EffectComposer.java	Added renderer.setViewportNeedsUpdate(true); call immediately after binding scene buffer and setting viewport, ensuring viewport synchronization during scene rendering initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A viewport update, small but true,
Placed just right in the render queue,
When scenes are bound and pixels align,
The renderer knows—everything's fine! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: preserving aspect-correct viewport when screen effects are applied.
Description check	✅ Passed	PR description includes clear issue explanation, recording/image, and completed checklist items, though Type of Change section is missing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

[phobos665]

Seems sensible. Thanks for fixing.