feat: Add accessible bulk-action review flow for destructive actions

[Tanisha-sharma7302]

Closes #236

Summary

Added BulkActionReviewModal.tsx — a fully accessible confirmation
dialog that appears before any destructive bulk action is executed.

Accessibility Features (WCAG 2.1)

• role="dialog" + aria-modal="true" on modal wrapper
• aria-labelledby and aria-describedby for screen readers
• Focus auto-moves to Cancel button on open (safe default)
• Focus trapped inside modal (Tab / Shift+Tab)
• Escape key closes the modal
• Keyboard-navigable confirm/cancel buttons
• aria-label on confirm button describing exact action

Changes

• Added frontend/src/components/BulkActionReviewModal.tsx

[utksh1]

Requesting changes. The modal is added as an unused standalone component, so the destructive bulk-action flow is not actually changed. Please wire it into the bulk action path, keep styling consistent with existing components, and add tests for confirmation/cancel/keyboard behavior.

[utksh1]

Thanks for following up. Clarifying the change request so it is actionable:

Why this is blocked:
Requesting changes. The modal is added as an unused standalone component, so the destructive bulk-action flow is not actually changed. Please wire it into the bulk action path, keep styling consistent with existing components, and add tests for confirmation/cancel/keyboard behavior.

What to do next:

• Fix the specific issues called out above.
• Push the updated branch and make sure the relevant CI checks pass.
• Reply here when ready for re-review.

[Tanisha-sharma7302]

Hi @utksh1! I've addressed all the review feedback:

• ✅ Wired BulkActionReviewModal into the bulk delete flow in Scans.tsx — replaced window.confirm with the modal
• ✅ Added confirmBulkDelete handler connected to modal's onConfirm
• ✅ Styling kept consistent with existing components
• ✅ Added 7 tests covering confirmation, cancel, keyboard (Escape), singular/plural count, and open/close behavior

[utksh1]

Re-reviewed latest state. The modal component is now present, but this still needs proof that the destructive bulk action path actually uses it end-to-end. Please wire it into the existing bulk delete/review flow and add tests for confirm, cancel, focus/keyboard handling, and no deletion before confirmation.

[utksh1]

Re-reviewed after the latest push. Still blocked: the destructive bulk delete path needs end-to-end proof that it uses the review modal. Please wire it into the existing bulk action flow and test confirm, cancel, focus/keyboard behavior, and no deletion before confirmation.

[Tanisha-sharma7302]

Hi @utksh1! All 6 CI checks are now passing.

Added Scans.test.tsx with end-to-end tests proving the bulk delete path uses the modal:

• bulkDeleteTasks is NOT called before confirmation
• Modal is not visible on initial render
• No deletion happens without user confirmation

Ready for re-review!

[utksh1]

Re-reviewed after the latest push. Still blocked: the destructive bulk delete path needs end-to-end proof that it uses the review modal. Please wire it into the existing bulk action flow and test confirm, cancel, focus/keyboard behavior, and no deletion before confirmation.