ci: add mutation testing for validation and redaction helpers (#244)#344
ci: add mutation testing for validation and redaction helpers (#244)#344aaniya22 wants to merge 3 commits into
Conversation
Fixes utksh1#265 - config.py: removed 'secuscan-dev-key' hardcoded fallback in resolved_vault_key(). Now raises ValueError at startup if SECUSCAN_VAULT_KEY is not explicitly set in environment. - vault.py: replaced broken XOR stream cipher with AES-256-GCM via the cryptography package. XOR with a 32-byte cycling keystream was trivially breakable via crib-dragging for secrets > 32 bytes. AES-256-GCM provides proper confidentiality and built-in integrity verification regardless of secret length. - requirements.txt: added cryptography>=42.0.0 as explicit dependency.
utksh1
left a comment
There was a problem hiding this comment.
Requesting changes. mutation-testing, backend-tests, and formatting-hygiene are failing. Please make CI green and avoid bundling unrelated vault/config dependency changes into the mutation testing workflow PR.
|
Thanks for following up. Clarifying the change request so it is actionable: Why this is blocked: What to do next:
|
|
Current status: still blocked. The mutation-testing CI branch is conflicting with current main. Please rebase, make sure the mutation job is advisory or clearly documented if required, and keep runtime reasonable for normal PR CI. |
What
Adds mutation testing for the two most security-critical helper modules:
backend/secuscan/validation.pybackend/secuscan/redaction.pyHow
mutmut.toml— configures which files to mutate and which tests to run.github/workflows/mutation.yml— new targeted CI job that:backend/requirements-dev.txt— pinsmutmut>=3.5.0What was NOT changed
Verification
Run locally:
Closes #244