feat: Export findings directly to Jira and GitHub Issues (#377)#391
feat: Export findings directly to Jira and GitHub Issues (#377)#391Somil450 wants to merge 8 commits into
Conversation
utksh1
left a comment
There was a problem hiding this comment.
Thanks for taking on this integration feature. I cannot merge this in its current state.\n\nRequested changes:\n- Resolve the merge conflicts first; GitHub reports this branch as conflicting/dirty.\n- Fix the failing CI jobs: backend-tests, frontend-checks, and formatting-hygiene.\n- Do not send Jira/GitHub tokens from frontend/localStorage in the ticket creation request. Integration credentials need to be stored and used server-side via the existing vault/settings flow, with redaction and no secret exposure in browser state.\n- Avoid rewriting almost all of backend/secuscan/routes.py; keep the diff focused so the integration can be reviewed safely.\n- Add backend tests for Jira/GitHub error handling and frontend tests/coverage for the export flow once the security model is corrected.\n\nThe feature is useful, but this needs a narrower, secure implementation before approval.
|
Hi @utksh1, thanks for the detailed review! I've addressed all the concerns and pushed the latest changes can u plz check. |
utksh1
left a comment
There was a problem hiding this comment.
Re-reviewed latest state. The main blocker still stands: Jira/GitHub integration credentials must not be supplied from browser/localStorage in the ticket export request. Please move credentials to a server-side settings/vault-backed flow with redaction, keep routes.py changes focused, and add backend/frontend tests for the corrected security model.
|
Re-reviewed after the latest push. Still blocked: Jira/GitHub export credentials must not be supplied from browser/localStorage in the export request. Please move credentials to a server-side settings/vault-backed flow with redaction and rebase the conflicting branch. |
Fixes: #377
🚀 Description
This PR bridges the gap between vulnerability discovery and remediation by allowing users to export findings directly from the dashboard into Jira tickets or GitHub Issues.
🛠️ Changes Made
httpxtorequirements.txtfor making asynchronous API calls.POST /api/v1/integrations/ticketendpoint to handle ticket creation requests.create_jira_ticketandcreate_github_issuelogic inintegrations.py, properly mapping the vulnerability data (Title, Severity, Description, Target, Remediation) into the respective issue formats.createTicketto the API layer and integrated toast notifications for success/error handling when creating a ticket.✅ How to Test