Skip to content

added scan history#409

Open
sultanafariza07 wants to merge 2 commits into
utksh1:mainfrom
sultanafariza07:feature-name
Open

added scan history#409
sultanafariza07 wants to merge 2 commits into
utksh1:mainfrom
sultanafariza07:feature-name

Conversation

@sultanafariza07
Copy link
Copy Markdown

Added scan history improvements in the frontend scan page.

Changes made:
Added scan-related type definitions:
Severity
ScanStatus
ExpectedFeatures
Improved task typing for better type safety and maintainability.
Added optional filtering fields for scan history:
severity
plugin type
expected features
Updated scan status handling to use reusable ScanStatus type.
Improved compatibility with older backend data using optional fields.
Related Issues

Closes #issue-number

Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
How Has This Been Tested?
Ran the frontend locally using Vite.
Verified scan history rendering and filtering behavior.
Confirmed TypeScript compilation works without errors.
Checklist
My code follows the code style of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.

@sultanafariza07
Copy link
Copy Markdown
Author

hi @utksh1 i added scan history and all checks have passed plz merge this pr

@sultanafariza07 sultanafariza07 changed the title Feature name added scan history May 29, 2026
@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:feature Feature work category bonus label area:frontend Frontend React/UI work gssoc:invalid Admin validation: invalid for GSSoC scoring labels May 29, 2026
Copy link
Copy Markdown
Owner

@utksh1 utksh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I can’t merge this as scan history yet: the diff only adds client-side filters to the existing Scans page, changes package-lock metadata without a dependency change, and relies on fields like severity/plugin_type that older/current task payloads may not provide. Please remove the unrelated lockfile churn, align the UI with actual scan-history requirements/data, and add focused tests for the filtering/history behavior before re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend React/UI work gssoc:invalid Admin validation: invalid for GSSoC scoring level:beginner 20 pts difficulty label for small beginner-friendly PRs type:feature Feature work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants