added scan history#409
Open
sultanafariza07 wants to merge 2 commits into
Open
Conversation
Author
|
hi @utksh1 i added scan history and all checks have passed plz merge this pr |
utksh1
requested changes
May 29, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the update. I can’t merge this as scan history yet: the diff only adds client-side filters to the existing Scans page, changes package-lock metadata without a dependency change, and relies on fields like severity/plugin_type that older/current task payloads may not provide. Please remove the unrelated lockfile churn, align the UI with actual scan-history requirements/data, and add focused tests for the filtering/history behavior before re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added scan history improvements in the frontend scan page.
Changes made:
Added scan-related type definitions:
Severity
ScanStatus
ExpectedFeatures
Improved task typing for better type safety and maintainability.
Added optional filtering fields for scan history:
severity
plugin type
expected features
Updated scan status handling to use reusable ScanStatus type.
Improved compatibility with older backend data using optional fields.
Related Issues
Closes #issue-number
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
How Has This Been Tested?
Ran the frontend locally using Vite.
Verified scan history rendering and filtering behavior.
Confirmed TypeScript compilation works without errors.
Checklist
My code follows the code style of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.