Skip to content

Fix race condition in task cancellation handling #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avnithakur731-a wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix race condition in task cancellation handling #421

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1f35b5
Fix race condition in task cancellation handling
Avnithakur731-a May 30, 2026
cb23beb
Fix formatting issue
Avnithakur731-a May 30, 2026
c8eba00
Remove trailing whitespace
Avnithakur731-a May 30, 2026
45e413d
Restore cancelled task state transition
Avnithakur731-a May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/secuscan/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,8 @@ async def cancel_task(self, task_id: str) -> bool:
)

await self._broadcast(task_id, "status", TaskStatus.CANCELLED.value)
await self._invalidate_cached_views()

await self._invalidate_cached_views()
await db.log_audit(
"task_cancelled",
"Task cancelled by user",
Expand All @@ -659,7 +659,7 @@ async def get_task_status(self, task_id: str) -> Optional[Dict]:
task_row = await db.fetchone(
"""
SELECT id, plugin_id, tool_name, target, status, scan_phase, created_at, started_at, completed_at,
duration_seconds, exit_code, error_message, preset, inputs_json
duration_seconds, exit_code, error_message, preset, inputs_json
FROM tasks WHERE id = ?
""",
(task_id,)
Expand Down Expand Up @@ -828,7 +828,7 @@ async def _upsert_findings_and_report_from_scanner(self, db, task_id: str, scann
exploitability, confidence, asset_exposure,
risk_score, risk_factors_json
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?)
?, ?, ?, ?, ?)
""",
(
finding_id,
Expand Down
Loading