feat: add notifications & alert system for long-running tasks (closes…#430
Open
sudha09-git wants to merge 2 commits into
Open
feat: add notifications & alert system for long-running tasks (closes…#430sudha09-git wants to merge 2 commits into
sudha09-git wants to merge 2 commits into
Conversation
…tksh1#337) - Add NotificationContext with useNotifications hook - Add NotificationBell component with unread badge counter - Add notification dropdown panel with read/unread states - Support mark as read, mark all as read, clear all actions - Integrate browser Web Notifications API with permission handling - Add bell icon to desktop sidebar and mobile header - Persist up to 50 notifications with timestamps - Match existing SecuScan brutalist UI design system
Author
|
/as all the ci are passed so kindly merge this PR |
utksh1
added
level:advanced
utksh1
requested changes
May 31, 2026
Owner
utksh1
left a comment
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the notification UI work. This currently adds a local notification center, but it is not wired to long-running task events or backend/task status changes, so it does not actually implement alerts for long-running tasks. It also requests browser notification permission on mount, before user intent. Please connect it to real task-duration/status signals and request browser permission from an explicit user action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v## Summary
Implements a full notifications and alert system for SecuScan.
Closes #337
Type of Change
Changes Made
NotificationContext.tsxwithNotificationProvideranduseNotificationshookNotificationBellcomponent with unread badge counter in sidebar and mobile headerHow to Test
addNotification()fromuseNotificationsChecklist
npm run build)