fix(docker): remove out-of-context plugins COPY, fix app entrypoint and host binding#442
Merged
utksh1 merged 2 commits intoMay 31, 2026
Conversation
utksh1
approved these changes
May 31, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Looks good: fixes the backend Dockerfile entrypoint/host binding and removes the invalid plugins COPY for the current compose build context; checks are green.
…ext-and-entrypoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three inconsistencies in the backend Dockerfile that prevented
docker compose up --buildfrom working on a clean checkout.Closes #381.
Changes
backend/DockerfileCOPY plugins ./plugins— theplugins/directory isoutside the
./backendbuild context so this line caused a buildfailure. Plugins are already mounted correctly via the compose
volume
./plugins:/app/plugins, making the COPY redundant.secuscan.api:apptosecuscan.main:appto match the actual FastAPI application module.
--host 127.0.0.1to--host 0.0.0.0so uvicorn binds toall interfaces inside the container and is reachable from the host
via the mapped port.
How to test
docker compose up --buildhttp://127.0.0.1:8081/api/v1/healthNotes
docker-compose.ymlis unchanged — the compose file was alreadycorrect with
context: ./backendand the plugins volume mountCloses #381