fix: use dict.get() instead of getattr() for plugin category#448
Merged
utksh1 merged 3 commits intoMay 31, 2026
Merged
Conversation
utksh1
approved these changes
May 31, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Looks good: focused one-line fix for get_plugins_summary using dict access for list_plugins() results; existing route coverage covers the summary response shape.
…ategory-getattr-clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
getattr(plugin, 'category', 'Unknown')withplugin.get('category', 'Unknown')in/api/v1/plugins/summarysince plugins are dicts, not objects.Related Issues
Split from #433 as requested by maintainer.
Type of Change