fix(plugins): prevent path traversal in wordlist file resolution#449
Open
ionfwsrijan wants to merge 1 commit into
Open
fix(plugins): prevent path traversal in wordlist file resolution#449ionfwsrijan wants to merge 1 commit into
ionfwsrijan wants to merge 1 commit into
Conversation
- Add _reject_path_traversal() to block parent-directory traversal - Add _is_path_in_wordlists_dir() to constrain resolved paths to the configured wordlists directory - Raise ValueError when an existing path resolves outside the allowed directory, preventing arbitrary filesystem access - Keep aliases and fallback resolution within wordlists_dir - Reject absolute paths and '..' traversal by default
Contributor
Author
|
@utksh1 You may review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds path traversal protection to the wordlist resolution logic in
plugins.py. The change validates that all wordlist paths are contained withinsettings.wordlists_dirand rejects any path containing parent directory traversal (..), preventing arbitrary file reads.Related Issues
Closes #445
Type of Change
How Has This Been Tested?
../— returns a clear errorsettings.wordlists_dir— rejectedsettings.wordlists_dir— resolves correctlyChecklist