fix(cache): add LRU eviction and opportunistic expired-key sweep#450
Open
ionfwsrijan wants to merge 1 commit into
Open
fix(cache): add LRU eviction and opportunistic expired-key sweep#450ionfwsrijan wants to merge 1 commit into
ionfwsrijan wants to merge 1 commit into
Conversation
- Add max entry cap with LRU eviction when cache exceeds capacity - Add opportunistic sweep of expired entries every N writes - Add LRU access tracking to evict least recently used entries first - Expose size property and stats for monitoring cache health - Prevent unbounded memory growth in long-running processes
Contributor
Author
|
@utksh1 You may review and merge |
utksh1
added
level:intermediate
utksh1
requested changes
May 31, 2026
Owner
utksh1
left a comment
utksh1
left a comment
There was a problem hiding this comment.
Thanks for tightening the in-memory cache. Please add focused unit coverage before merge: LRU eviction order, expiry cleanup removing access-order entries, delete_prefix cleanup, and edge cases such as max_entries <= 0. Cache eviction changes are easy to regress and this PR currently has no tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds memory-safety guarantees to the in-memory cache client: a maximum entry cap with LRU eviction, an opportunistic expired-key sweep, and monitoring properties (
size,stats) to prevent unbounded memory growth in long-running processes.Related Issues
Closes #446
Type of Change
How Has This Been Tested?
statsandsizeafter evictions and sweeps; confirmed counters incrementedChecklist