fix(modal): prevent double onConfirm and add body scroll lock#462
Merged
utksh1 merged 2 commits intoJun 1, 2026
Merged
Conversation
utksh1
added
level:beginner
utksh1
approved these changes
Jun 1, 2026
Owner
utksh1
left a comment
utksh1
left a comment
There was a problem hiding this comment.
Reviewed after the main merge. The change prevents duplicate Enter/onClick confirmation handling, restores body scroll state on cleanup, and all CI checks are green. Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #460