Skip to content

Commit 6075515

Browse files
committed
refactor(chart-view): remove unnecessary ngOnChanges method for cleaner code
1 parent e452246 commit 6075515

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

frontend/src/app/graphic-builder/shared/components/viewer/chart-view/chart-view.component.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ require('echarts-wordcloud');
3939
styleUrls: ['./chart-view.component.scss'],
4040
changeDetection: ChangeDetectionStrategy.OnPush
4141
})
42-
export class ChartViewComponent implements OnInit, OnChanges, OnDestroy {
42+
export class ChartViewComponent implements OnInit, OnDestroy {
4343

4444
@Input() chartId: number;
4545
@Input() building: boolean;
@@ -72,14 +72,10 @@ export class ChartViewComponent implements OnInit, OnChanges, OnDestroy {
7272
private timeFilterBehavior: TimeFilterBehavior) {
7373
}
7474

75-
ngOnChanges(changes: SimpleChanges) {
76-
this.refreshType = `${this.chartId}`;
77-
this.refreshService.sendRefresh(this.refreshType);
78-
}
79-
8075
ngOnInit() {
8176
this.defaultTime = resolveDefaultVisualizationTime(this.visualization);
8277
this.refreshType = `${this.chartId}`;
78+
8379
this.data$ = this.refreshService.refresh$
8480
.pipe(
8581
takeUntil(this.destroy$),

frontend/src/app/graphic-builder/shared/components/viewer/table-view/table-view.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class TableViewComponent implements OnInit, OnChanges, OnDestroy {
133133

134134
ngOnChanges(changes: SimpleChanges) {
135135
this.refreshType = `${this.chartId}`;
136-
this.refreshService.sendRefresh(this.refreshType);
136+
137137
if (changes.height && changes.height.currentValue !== 'NaNpx') {
138138
const currentGridHeight = Number(changes.height.currentValue.replace('px', ''));
139139
if (!isNaN(currentGridHeight)) {

0 commit comments

Comments
 (0)