Skip to content

V12- fix(forwarder): set gRPC metadata type to collector instead of agent#2291

Merged
Kbayero merged 1 commit into
release/v12.0.0from
backlog/fix_forwarder_grpc_metadata_type
Jun 29, 2026
Merged

V12- fix(forwarder): set gRPC metadata type to collector instead of agent#2291
Kbayero merged 1 commit into
release/v12.0.0from
backlog/fix_forwarder_grpc_metadata_type

Conversation

@yllada

@yllada yllada commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #2290

Summary

The forwarder was sending type: "agent" in the outgoing gRPC metadata context.
The log-auth-proxy rejects streams that don't identify as "collector", causing
an EOF loop that prevented any logs from being forwarded.

Changes

File Change
collectors/forwarder/serv/service.go Changed metadata type value from "agent" to "collector"

@yllada yllada requested a review from Kbayero June 29, 2026 13:32
@github-actions

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Modification of gRPC metadata 'type' field in forwarder service potentially breaks agent-manager authentication or routing logic.

  • high collectors/forwarder/serv/service.go:91 — Changing the 'type' metadata from 'agent' to 'collector' alters the identification contract with the agent-manager. This may break authentication, authorization, or routing logic for existing deployments and requires a coordinated rollout plan.

bugs (gemini-3-flash-lite) — clean

Summary: Minor change to outgoing context metadata; no functional bugs detected.

No findings.

security (gemini-3-flash-lite) — clean

Summary: Change of metadata type from 'agent' to 'collector' in gRPC context; no security impact.

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@yllada yllada changed the title fix(forwarder): V12 set gRPC metadata type to collector instead of agent V12- fix(forwarder): set gRPC metadata type to collector instead of agent Jun 29, 2026
@Kbayero Kbayero merged commit 88f27b3 into release/v12.0.0 Jun 29, 2026
4 of 6 checks passed
@Kbayero Kbayero deleted the backlog/fix_forwarder_grpc_metadata_type branch June 29, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(forwarder): set gRPC metadata type to "collector" instead of "agent"

2 participants