Skip to content

Backlog/v12 nginx routes#2294

Merged
Kbayero merged 3 commits into
release/v12.0.0from
backlog/v12_nginx_routes
Jun 30, 2026
Merged

Backlog/v12 nginx routes#2294
Kbayero merged 3 commits into
release/v12.0.0from
backlog/v12_nginx_routes

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Modification to installer templates and Nginx routing configuration affecting infrastructure and API accessibility.

  • high installer/templates/front-end.go:35 — Modification to installer templates requires Tier 3 review as it alters infrastructure deployment and routing logic for the SOAR websocket endpoint.
  • medium installer/templates/front-end.go:11 — Removal of '$uri/' from try_files may break deep-linking for existing Angular/React routes; verify if this change is intended to restrict directory listing or if it impacts SPA navigation.

🛑 bugs (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Removal of $uri/ from try_files will break SPA routing for sub-paths and directory-based assets.

  • high installer/templates/front-end.go:11 — Removing $uri/ from try_files prevents Nginx from serving directory indexes or correctly resolving SPA routes that rely on trailing slashes, likely breaking navigation for users.

🛑 security (gemini-3-flash-lite) — blocking — must fix before merge

Summary: New WebSocket proxy configuration added to Nginx template; requires verification of backend authentication handling for upgraded connections.

  • medium installer/templates/front-end.go:35 — New WebSocket endpoint (/api/v1/soar/ws/) introduced. Ensure the backend correctly validates authentication/authorization for WebSocket upgrades, as standard HTTP middleware may be bypassed.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@Kbayero Kbayero merged commit f0cda86 into release/v12.0.0 Jun 30, 2026
4 of 6 checks passed
@Kbayero Kbayero deleted the backlog/v12_nginx_routes branch June 30, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants