Skip to content

fix[frontend](data_sources): removed loading indicator after output arrives from command execution#2334

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_command_load_indicator
Jul 9, 2026
Merged

fix[frontend](data_sources): removed loading indicator after output arrives from command execution#2334
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_command_load_indicator

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

architecture (gemini-3-flash-lite) — clean

Summary: Minor UI state management adjustment in AgentConsole; no architectural or contract impact.

No findings.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Logic error: onOutput callback prematurely sets running state to false, causing UI to stop tracking agent execution after the first chunk of output.

  • high frontend/src/features/datasources/components/AgentConsole.tsx:117 — The setRunning(false) call inside onOutput will terminate the 'running' state as soon as the first byte of output is received, rather than waiting for the process to complete. This should be removed from onOutput and handled only in onDone.

⚠️ security (gemini-3-flash-lite) — minor findings

Summary: Race condition in AgentConsole output handling leads to premature state update.

  • medium frontend/src/features/datasources/components/AgentConsole.tsx:117 — The 'setRunning(false)' call inside 'onOutput' triggers prematurely if the agent streams partial output. This may cause the UI to incorrectly report the command as finished while it is still executing. Move 'setRunning(false)' exclusively to the 'onDone' callback to ensure accurate state management.

🔴 go-deps — pending updates

🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./agent/updater:
     - github.com/kardianos/service: v1.2.4 → v1.3.0

  📁 ./agent:
     - github.com/kardianos/service: v1.2.4 → v1.3.0
     - golang.org/x/sys: v0.46.0 → v0.47.0
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./collectors/as400:
     - github.com/kardianos/service: v1.2.4 → v1.3.0
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./collectors/utmstack:
     - github.com/kardianos/service: v1.2.4 → v1.3.0
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./collectors/forwarder:
     - github.com/kardianos/service: v1.2.4 → v1.3.0
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./installer:
     - github.com/cloudfoundry/gosigar: v1.3.122 → v1.3.123
     - github.com/kardianos/service: v1.2.4 → v1.3.0

  📁 ./backend:
     - cloud.google.com/go/pubsub: v1.50.2 → v1.50.4
     - github.com/aws/aws-sdk-go-v2/config: v1.32.25 → v1.32.29
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.24 → v1.19.28
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.78.0 → v1.79.0
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.43.3 → v1.44.0
     - golang.org/x/crypto: v0.53.0 → v0.54.0
     - google.golang.org/api: v0.286.0 → v0.287.1
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./plugins/inputs:
     - google.golang.org/grpc: v1.81.1 → v1.82.0

  📁 ./plugins/sophos:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/gcp:
     - cloud.google.com/go/pubsub: v1.50.2 → v1.50.4
     - golang.org/x/crypto: v0.53.0 → v0.54.0
     - google.golang.org/api: v0.286.0 → v0.287.1

  📁 ./plugins/crowdstrike:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/bitdefender:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/azure:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.42.0 → v1.42.1
     - github.com/aws/aws-sdk-go-v2/config: v1.32.25 → v1.32.29
     - github.com/aws/aws-sdk-go-v2/credentials: v1.19.24 → v1.19.28
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.78.0 → v1.79.0
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/soc-ai:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./plugins/feeds:
     - golang.org/x/sync: v0.21.0 → v0.22.0

  📁 ./plugins/o365:
     - golang.org/x/crypto: v0.53.0 → v0.54.0

  📁 ./agent-manager:
     - golang.org/x/sync: v0.21.0 → v0.22.0
     - google.golang.org/grpc: v1.81.1 → v1.82.0

❌ Please update dependencies before merging.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

from backend and agent manager side command outputs are sent in one message, so keep loading until is done will lock the console for the user even if command execution has return already, thats why loader was removed after on output

@AlexSanchez-bit AlexSanchez-bit merged commit 744a067 into release/v12.0.0 Jul 9, 2026
1 check passed
@AlexSanchez-bit AlexSanchez-bit deleted the backlog/v12_command_load_indicator branch July 9, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant