Exercise solved - Sebastián Moreyra#34
Open
SebastianMoreyraUTN wants to merge 1 commit intoutnfrrottads:servicesfrom
SebastianMoreyraUTN:services
Open
Exercise solved - Sebastián Moreyra#34SebastianMoreyraUTN wants to merge 1 commit intoutnfrrottads:servicesfrom SebastianMoreyraUTN:services
SebastianMoreyraUTN wants to merge 1 commit intoutnfrrottads:servicesfrom
SebastianMoreyraUTN:services
Conversation
aotaduy
reviewed
Jul 15, 2020
| } | ||
|
|
||
| setTasks(list) { | ||
| localStorage.setItem("taskList",JSON.stringify(list)); |
Contributor
There was a problem hiding this comment.
usemos comillas simples, seamos consistentes con estos detalles
| constructor(private storage: LocalStorageService) { } | ||
| constructor(private storage: LocalStorageService) { | ||
| this.list = this.storage.getTasks(); | ||
| console.log(this.list); |
Contributor
There was a problem hiding this comment.
saqquemos los console.log antes de entregar el ¨PR
| } | ||
| getLastId() { | ||
| let lastId = 0; | ||
| this.list.forEach(e => { |
Contributor
There was a problem hiding this comment.
evitemos totdo tipo de abreviaciones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hola profe, creo mi pull request del ejercicio de Servicios.
Saludos!!!